From e316aeee994307fd7af2dd8bce0da92ba09f3205 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ask=20Bj=C3=B8rn=20Hansen?= Date: Mon, 6 Jan 2025 19:31:19 +0100 Subject: [PATCH] db: less logging when opening a database connection --- chdb/db.go | 2 +- ntpdb/dbconn.go | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/chdb/db.go b/chdb/db.go index 2867acc..235822a 100644 --- a/chdb/db.go +++ b/chdb/db.go @@ -40,7 +40,7 @@ func New(ctx context.Context, dbConfigPath string) (*ClickHouse, error) { func setupClickhouse(ctx context.Context, configFile string) (*ClickHouse, error) { log := logger.FromContext(ctx) - log.InfoContext(ctx, "opening config", "file", configFile) + log.DebugContext(ctx, "opening ch config", "file", configFile) dbFile, err := os.Open(configFile) if err != nil { diff --git a/ntpdb/dbconn.go b/ntpdb/dbconn.go index ea11170..33274da 100644 --- a/ntpdb/dbconn.go +++ b/ntpdb/dbconn.go @@ -5,7 +5,6 @@ import ( "database/sql" "database/sql/driver" "fmt" - "log" "os" "time" @@ -27,7 +26,7 @@ type DBConfig struct { func OpenDB(ctx context.Context, configFile string) (*sql.DB, error) { log := logger.FromContext(ctx) - dbconn := sql.OpenDB(Driver{CreateConnectorFunc: createConnector(configFile)}) + dbconn := sql.OpenDB(Driver{CreateConnectorFunc: createConnector(ctx, configFile)}) dbconn.SetConnMaxLifetime(time.Minute * 3) dbconn.SetMaxOpenConns(8) @@ -42,9 +41,10 @@ func OpenDB(ctx context.Context, configFile string) (*sql.DB, error) { return dbconn, nil } -func createConnector(configFile string) CreateConnectorFunc { +func createConnector(ctx context.Context, configFile string) CreateConnectorFunc { + log := logger.FromContext(ctx) return func() (driver.Connector, error) { - log.Printf("opening config file %s", configFile) + log.DebugContext(ctx, "opening db config file", "filename", configFile) dbFile, err := os.Open(configFile) if err != nil {