From 0edce7bab9f4f3b63d5cc8f0dbc019e10138a30a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ask=20Bj=C3=B8rn=20Hansen?= <ask@develooper.com>
Date: Sun, 22 Dec 2024 17:40:51 -0800
Subject: [PATCH] tracing: better span names

---
 geoipapi.go | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/geoipapi.go b/geoipapi.go
index 88aa24a..300a937 100644
--- a/geoipapi.go
+++ b/geoipapi.go
@@ -148,6 +148,8 @@ func getCity(req *http.Request) (*geoip2.City, error) {
 }
 
 func handleJSON(w http.ResponseWriter, req *http.Request) {
+	span := trace.SpanFromContext(req.Context())
+	span.SetName("/api/json")
 	city, err := getCity(req)
 	if err != nil {
 		log.Printf("getCity error: %s", err)
@@ -166,6 +168,9 @@ func handleJSON(w http.ResponseWriter, req *http.Request) {
 }
 
 func handleCountry(w http.ResponseWriter, req *http.Request) {
+	span := trace.SpanFromContext(req.Context())
+	span.SetName("/api/country")
+
 	city, err := getCity(req)
 	if err != nil {
 		log.Printf("getCity error: %s", err)
@@ -178,6 +183,10 @@ func handleCountry(w http.ResponseWriter, req *http.Request) {
 }
 
 func handleHealth(w http.ResponseWriter, req *http.Request) {
+	span := trace.SpanFromContext(req.Context())
+	span.SetAttributes(attribute.Bool("app.drop_sample", true))
+	span.SetName("/healthz")
+
 	ip := net.ParseIP("199.43.0.43")
 	city, err := getCityIP(ip)
 	if err != nil {